At the moment, and until we close #242, the report only shows the contents of the log file. Once we have the participant files and we restructure the output into folders, the report will show the folder structure and the plots generated by phys2bids.

@smoia let me know if the Brainhack and Enhancement labels should be removed.

Codecov Report

Merging #243 (dbdf365) into master (e50e3cd) will increase coverage by 0.34%.
The diff coverage is 98.78%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   94.77%   95.12%   +0.34%     
==========================================
  Files           8        9       +1     
  Lines         862      944      +82     
==========================================
+ Hits          817      898      +81     
- Misses         45       46       +1     

Hi! 👋 I'd like to help with report generating and I'm curious about what you all would ultimately like the report to look like/contain.

At the moment, and until we close #242, the report only shows the contents of the log file. Once we have the participant files and we restructure the output into folders, the report will show the folder structure and the plots generated by phys2bids.

Based on this comment, report would contain folder structure + plots? Dynamic plots?! ( 😄)

Let me know! (I know it's late, though, no rush)

Hey Katie! Thanks for collaborating with us!

Ideally it should contain the folder structure generated by physbids, as well as the channel plot (if requested by the user) and the trigger plot. That’s my opinion though.

@smoia anything else you think we should cover?

... Did anyone say "dynamic"?

If you want to add a bit of bokeh magic, please do so!
The channel plot, if interactive, could become a quality check!

We have to get this merged in before ISMRM.

Any idea why the tests are failing @tsalo ? Afaik tmp_path_factory.getbasetemp() should already create the folder where the data is stored. I don't know what else could be raising this error. When I use a breakpoint first thing in the test, I do not see this error. I only see it when run with no breakpoints.

Ok, it looks like the tests pass again. Good catch @vinferrer !

@62442katieb @smoia @vinferrer @tsalo @RayStick the PR is ready for review now!

Looks like we figured out what was going on with the logger and the Windows tests. Thank you @vinferrer for your help.

Apparently, the log file generated by test_integration_acq was being read by test_integration_heuristics because it was the first tsv file in the directory. When phys2bids is run through Python and not the terminal, no logs are generated on Linux but apparently, an empty log file is generated on Windows. This empty log file was being read by the test, which caused the errors.